keannu125/StudE-Backend
1
0
Fork 0
mirror of https://github.com/lemeow125/StudE-Backend.git synced 2024-11-17 06:19:24 +08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Delete study group if no students are left

Browse source
This commit is contained in:
Keannu Bernasol 2023-09-29 11:33:48 +08:00
parent c5f04328e5
commit c0992267b4
1 changed files with 20 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
stude/student_status/serializers.py
View file

@ -35,26 +35,39 @@ class StudentStatusSerializer(serializers.ModelSerializer):
def update(self, instance, validated_data): def update(self, instance, validated_data):
active = validated_data.get('active', None) active = validated_data.get('active', None)
subject = validated_data.get('subject', None) # If status is set as false in PATCH, clear the student status
print('=====', subject, '======')
# If status is set as false in the request, clear the student status
if active is False: if active is False:
validated_data['location'] = Point(0, 0) validated_data['location'] = Point(0, 0)
validated_data['subject'] = None validated_data['subject'] = None
validated_data['landmark'] = None validated_data['landmark'] = None
validated_data['study_group'] = None validated_data['study_group'] = None
elif ('active' in validated_data): # If status is set as true in PATCH
elif active is True:
# Check if subject is attached in PATCH, if not return error
if 'subject' not in validated_data: if 'subject' not in validated_data:
raise serializers.ValidationError( raise serializers.ValidationError(
{'subject': 'This field may not be empty if active is true'}) {'subject': 'This field may not be empty if active is true'})
# To-do: Add geofencing to ensure locations are always within USTP # Then check the location if it matches any landmarks
# Check each landmark to see if our location is within it
for landmark in Landmark.objects.all(): for landmark in Landmark.objects.all():
if landmark.location.contains(validated_data['location']): if landmark.location.contains(validated_data['location']):
validated_data['landmark'] = landmark validated_data['landmark'] = landmark
break break
return super().update(instance, validated_data) # Get new value for study group in PATCH
study_group = validated_data.get('study_group', None)
# Get old value in db
old_study_group = instance.study_group
# Commit changes
instance = super().update(instance, validated_data)
# If student has left study group, check if the old study_group no longer has any students
if study_group is None and old_study_group is not None:
if not old_study_group.students.exists():
# If there are no students left in the old StudyGroup, delete it
old_study_group.delete()
return instance
class StudentStatusLocationSerializer(serializers.ModelSerializer): class StudentStatusLocationSerializer(serializers.ModelSerializer):